Details about package xfce4-weather-plugin
Package uploads
Upload #1
Information
Changelog
xfce4-weather-plugin (0.11.3-1) unstable; urgency=medium
.
* Team upload.
* New upstream version 0.11.3.
* d/control: Bump Standards-Version to 4.7.0.
Comments
-
Mateusz,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: xfce4-weather-plugin: incorrect-locale-code hye -> hy [usr/share/locale/hye/]
N:
N: The package appears to ship locales for a language but uses an incorrect
N: locale code as a subdirectory of /usr/share/locale. This usually results
N: in users of the intended target language not finding the locale. The
N: language codes used in the locale directories are those from the ISO 639-1
N: and ISO 639-2 standards, not those usually used as TLDs (which are from
N: the ISO 3166 standard).
N:
N: When both standards define a language code for a given language, the ISO
N: 639-1 code should be used (i.e. the two lettered code).
N:
N: Lintian only knows about some commonly-mistaken set of incorrect locale
N: codes.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/locales
N:
N:
I: xfce4-weather-plugin: arch-dep-package-has-big-usr-share 4376kB 95%
N:
N: The package has a significant amount of architecture-independent data
N: (over 4MB, or over 2MB and more than 50% of the package) in /usr/share but
N: is an architecture-dependent package. This is wasteful of mirror space and
N: bandwidth since it means distributing multiple copies of this data, one
N: for each architecture.
N:
N: If the data in /usr/share is not architecture-independent, this is a
N: Policy violation that should be fixed by moving the data elsewhere
N: (usually /usr/lib).
N:
N: Please refer to Section 6.7.5 of the Debian Developer's Reference for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: huge-usr-share
N:
N:
I: xfce4-weather-plugin: package-contains-documentation-outside-usr-share-doc [usr/share/xfce4/weather/icons/liquid-dark/theme.info]
N:
N: This package ships a documentation file outside /usr/share/doc
N: Documentation files are normally installed inside /usr/share/doc.
N:
N: If this file doesn't describe the contents or purpose of the directory it
N: is in, please consider moving this file to /usr/share/doc/ or maybe even
N: removing it. If this file does describe the contents or purpose of the
N: directory it is in, please add a lintian override.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation
N:
N: Screen: python/egg/metadata
N: Advocates: "Scott Kitterman" <debian@kitterman.com>
N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N: Python modules. Those files are not documentation even though
N: some of their names carry the .txt file extension.
N:
N: Python modules can be both public and private.
N:
N: Read more in
N: https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N: https://www.python.org/dev/peps/pep-0376/#id16,
N: https://www.python.org/dev/peps/pep-0610/,
N: https://www.python.org/dev/peps/pep-0639/,
N: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N: and Bug#1003913.
N:
N:
I: xfce4-weather-plugin: package-contains-documentation-outside-usr-share-doc [usr/share/xfce4/weather/icons/liquid/theme.info]
N:
I: xfce4-weather-plugin: package-contains-documentation-outside-usr-share-doc [usr/share/xfce4/weather/icons/simplistic/theme.info]
E: Lintian run failed (runtime error)
3. Licenses [4]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/xfce4-weather-plugin-0.11.3$ lrc
en: Versions: recon 3.3 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
GPL-2+ | FSFULLR config.rpath
GPL-2+ | FSFAP INSTALL
4. Watch file [uscan --force-download]: Good
5. Build Twice (build source after successful build [1]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
I believe 'xfce4-weather-plugin' is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues.
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Needs work
Phil Wyett at Jan. 11, 2025, 5 a.m.
