Ha6,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information only
Running lintian...
N:
E: sredird: helper-templates-in-copyright
N:
N: The /usr/share/doc/*pkg*/copyright file still contains template markers
N: from a packaging helper. Please fill in the actual license, upstream
N: copyright holders, and download information about the package and remove
N: any remaining templates generated by the packaging helper.
N:
N: Visibility: error
N: Show-Always: no
N: Check: debian/copyright
N:
N:
W: sredird: copyright-without-copyright-notice
N:
N: The copyright file for this package does not appear to contain a copyright
N: notice. You should copy the copyright notice from the upstream source (or
N: add one of your own for a native package). A copyright notice must consist
N: of Copyright, Copr., or the Unicode symbol of C in a circle followed by
N: the years and the copyright holder. A copyright notice is not required for
N: a work to be copyrighted, but Debian requires the copyright file include
N: the authors and years of copyright, and including a valid copyright notice
N: is the best way to do that. Examples:
N:
N: Copyright YYYY Firstname Lastname <address@example.com>
N: Copr. YYYY-YYYY Firstname Lastname <address@example.com>
N: © YYYY,YYYY Firstname Lastname <address@example.com>
N:
N: If the package is in the public domain rather than copyrighted, be sure to
N: mention "public domain" in the copyright file. Please be aware that this
N: is very rare and not the same as a DFSG-free license. True public domain
N: software is generally limited to such special cases as a work product of a
N: United States government agency.
N:
N: Please refer to https://ftp-master.debian.org/REJECT-FAQ.html for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright
N:
N:
W: sredird source: debian-rules-ignores-make-clean-error [debian/rules:45]
N:
N: A rule in the debian/rules file for this package calls the package's clean
N: or distclean target with a line like:
N:
N: -$(MAKE) distclean
N:
N: or
N:
N: $(MAKE) -i distclean
N:
N: The leading "-" or the option -i tells make to ignore all errors. Normally
N: this is done for packages using Autoconf since Makefile may not exist.
N: However, this line ignores all other error messages, not just the missing
N: Makefile error. It's better to use:
N:
N: [ ! -f Makefile ] || $(MAKE) distclean
N:
N: so that other error messages from the clean or distclean rule will still
N: be caught (or just remove the "-" if the package uses a static makefile).
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/rules
N:
N:
W: sredird source: debian-rules-should-not-set-CFLAGS-from-noopt [debian/rules]
N:
N: The debian/rules file for this package appears to set CFLAGS if the value
N: of DEB_BUILD_OPTIONS contains noopt.
N:
N: This has been obsoleted in favour of dpkg-buildflags.
N:
N: Please refer to the dpkg-buildflags(1) manual page for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/rules
N:
N:
W: sredird-dbgsym: debug-file-with-no-debug-symbols [usr/lib/debug/.build-id/53/8446dccbc44ee3107f9ef45f40cac578b9930a.debug]
N:
N: The binary is installed as a detached "debug symbols" ELF file, but it
N: does not appear to have debug information associated with it.
N:
N: A common cause is not passing -g to GCC when compiling.
N:
N: Implementation detail: Lintian checks for the ".debug_line" and the
N: ".debug_str" sections. If either of these are present, the binary is
N: assumed to contain debug information.
N:
N: Please refer to Bug#668437 for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: binaries/debug-symbols/detached
N:
N:
W: sredird source: dh-clean-k-is-deprecated [debian/rules]
N:
N: This package calls dh_clean -k in its debian/rules file instead of
N: dh_prep.
N:
N: Please refer to the dh_clean(1) manual page for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debhelper
N:
N:
W: sredird source: package-uses-deprecated-debhelper-compat-version 9
N:
N: The debhelper compatibility version used by this package is marked as
N: deprecated by the debhelper developer. You should really consider using a
N: newer compatibility version.
N:
N: The compatibility version can be set by specifying debhelper-compat (= 12)
N: in your package's Build-Depends, by the legacy debian/compat file or even
N: by setting and exporting DH_COMPAT in debian/rules. If it is not set in
N: either place, debhelper defaults to the deprecated compatibility version
N: 1.
N:
N: Please refer to the debhelper(7) manual page for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debhelper
N:
N:
I: sredird source: debian-watch-file-is-missing
N:
N: This source package is not Debian-native but it does not have a
N: debian/watch file. This file is used for automatic detection of new
N: upstream versions by the Debian External Health Status project and other
N: project infrastructure. If this package is maintained upstream, please
N: consider adding a debian/watch file to detect new releases.
N:
N: If the package is not maintained upstream or if upstream uses a
N: distribution mechanism that cannot be meaningfully monitored by uscan and
N: the Debian External Health Status project, please consider adding a
N: debian/watch file containing only comments documenting the situation.
N:
N: Please refer to Upstream source location: debian/watch (Section 4.11) in
N: the Debian Policy Manual and the uscan(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/watch
N:
N:
I: sredird: hardening-no-bindnow [usr/sbin/sredird]
N:
N: This package provides an ELF binary that lacks the "bindnow" linker flag.
N:
N: This is needed (together with "relro") to make the "Global Offset Table"
N: (GOT) fully read-only. The bindnow feature trades startup time for
N: improved security. Please consider enabling this feature or consider
N: overriding the tag (possibly with a comment about why).
N:
N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or
N: hardening=+all to DEB_BUILD_MAINT_OPTIONS.
N:
N: The relevant compiler flags are set in LDFLAGS.
N:
N: Please refer to https://wiki.debian.org/Hardening for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: sredird: hardening-no-fortify-functions [usr/sbin/sredird]
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called by
N: any routines, all unfortified calls have already been fully validated at
N: compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N: directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: sredird source: no-dh-sequencer [debian/rules]
N:
N: This package does not use the dh sequencer in debian/rules.
N:
N: While maintainers may use a variety of build systems, this one is by far
N: the most popular.
N:
N: Maintainers are strongly encouraged to use the dh sequencer in new
N: packages and convert existing ones when appropriate.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/rules/dh-sequencer
N:
N:
I: sredird source: out-of-date-standards-version 3.5.8 (released 2002-11-15) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
I: sredird: package-contains-empty-directory [usr/bin/]
N:
N: This package installs an empty directory. This might be intentional but
N: it's normally a mistake. If it is intentional, add a Lintian override.
N:
N: If a package ships with or installs empty directories, you can remove them
N: in debian/rules by calling:
N:
N: $ find path/to/base/dir -type d -empty -delete
N:
N: Visibility: info
N: Show-Always: no
N: Check: files/empty-directories
N:
N:
I: sredird source: patch-not-forwarded-upstream [debian/patches/0001-Re-raise-deadly-signals-instead-of-ignoring-them-Clo.patch]
N:
N: According to the DEP-3 headers, this patch has not been forwarded
N: upstream.
N:
N: Please forward the patch and try to have it included in upstream's version
N: control system. If the patch is not suitable for that, please mention
N: not-needed in the Forwarded field of the patch header.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N: the upstream sources (Section 4.3) in the Debian Policy Manual, and
N: Bug#755153 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/dep3
N: Renamed from: send-patch
N:
N:
I: sredird source: patch-not-forwarded-upstream [debian/patches/0002-Fix-segfault-if-insufficient-arguments-and-some-star.patch]
N:
I: sredird: spelling-error-in-binary Unknwon Unknown [usr/sbin/sredird]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
I: sredird: typo-in-manual-page compatability compatibility [usr/share/man/man8/sredird.8.gz:20]
N:
N: Lintian found a spelling error in a manual page. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext (with the help of po4a, for example) or a similar tool, please fix
N: the error in the translations as well as the English text to avoid making
N: the translations fuzzy. With gettext, for example, this means you should
N: also fix the spelling mistake in the corresponding msgids in the *.po
N: files.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: spelling-error-in-manpage
N:
E: Lintian run failed (runtime error)
3. Licenses [4]: Information only
Not DEP-5 compliant.
4. Watch file [uscan --force-download]: N/A
5. Build Twice (build source after successful build [1]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
Acceptable for an NMU.
I hope discussion with the maintainer has taken place.
This package is in a shocking state and needs to be modernised and brought in-line with current Debian standards.
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Ready
Phil Wyett at Jan. 10, 2025, 7:47 p.m.
