Details about package quadrilateralcowboy
Package uploads
Upload #3
Information
Changelog
quadrilateralcowboy (0~20240909.git3e3947707-1) unstable; urgency=medium
.
[ James Addison ]
* Initial release. Closes: #1026277
Comments
No comments
Upload #2
Information
Changelog
quadrilateralcowboy (0~20240909.git3e3947707-1) unstable; urgency=medium
.
[ James Addison ]
* Initial release. Closes: #1026277
Comments
-
I forgot to re-run lintian after building this updated version of the package; it includes a missing LGPL license attribution for some OpenAL EAX-related files, but I used the wrong short-name for the license in the DEP5 file.
I'll re-upload after fixing that soon - likely within the next few days - and then will consider filing an RFS bug.
Needs work
James Addison at Oct. 10, 2024, 5:18 p.m.
Upload #1
Information
Changelog
quadrilateralcowboy (0~20240909-1) UNRELEASED; urgency=medium
.
[ James Addison ]
* Initial release. Closes: #1026277
Comments
-
James,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
The review below is for assistance. This review is offered to help package submitters to Debian mentors in order to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issues
E: quadrilateralcowboy changes: unreleased-changes
N:
N: The distribution in the Changes field copied from debian/changelog
N: indicates that this package was not intended to be released yet.
N:
N: Please refer to Bug#542747 for details.
N:
N: Visibility: error
N: Show-Always: no
N: Check: fields/distribution
N:
N:
I: quadrilateralcowboy: spelling-error-in-binary preceeding preceding [usr/games/qc]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
I: quadrilateralcowboy: spelling-error-in-binary scaleable scalable [usr/games/qc]
3. Licenses [4]: Issues
philwyett@ks-tarkin:~/Development/builder/debian/mentoring/quadrilateralcowboy-0~20240909$ lrc
en: Versions: recon 1.17.1 check 3.3.9-1
Parsing Source Tree ....
Reading copyright ....
Running licensecheck ....
d/copyright | licensecheck
MIT | Khronos renderer/glext.h
4. Watch file [uscan --force-download]: N/A
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issues
dpkg-source --before-build .
debian/rules clean
dh clean
dh_auto_clean
dh_clean
dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building quadrilateralcowboy using existing ./quadrilateralcowboy_0~20240909.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: warning: ignoring deletion of file qc.6, use --include-removal to override
dpkg-source: error: cannot represent change to qc.6.gz: binary file contents changed
dpkg-source: error: add qc.6.gz in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
I: copying local configuration
E: Failed autobuilding of package
I: unmounting dev/ptmx filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: cleaning the build env
I: removing directory /var/cache/pbuilder/build/57952 and its subdirectories
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Not performed at this time
8. Upgrade [Over previous installs if any]: N/A
Additional...
A. Consider filing an RFS bug, so a package review can be seen by many and when ready, marked as "confirmed" so then a DD can review and possibly upload the package into Debian.
Summary...
I believe <PACKAGE> is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Needs work
Phil Wyett at Sept. 9, 2024, 8:40 p.m.
-
Hi Phil,
Thank you very much for the detailed and addressable feedback. I've resolved each of the issues identified, and have pushed those changes to git on Salsa -- with the spelling errors corrected upstream (in this case, also maintained by myself).
Two items seem to remain:
* Opening an RFS ticket for the package.
* Resolving an ARM64 cross-build failure in Salsa's continuous integration pipelines.
I'd like to try to get the ARM64 cross-build working before opening the RFS. It may be an optional extra, but I would like to try to include one non-x86 architecture with the initial release.
Thanks again,
James
Needs work
James Addison at Sept. 10, 2024, 3:30 p.m.
