Sign me up Login

Details about package prometheus-phpfpm-exporter

Name: prometheus-phpfpm-exporter
Uploader: Nicolas Peugnet <nicolas@club1.fr> (Debian QA page)
Description: prometheus-phpfpm-exporter - Prometheus exporter for PHP-FPM

Package uploads

Upload #3

Information

Version: 0.6.0-1
Uploaded: 2024-09-26 18:55
Source package: prometheus-phpfpm-exporter_0.6.0-1.dsc
Distribution: unstable
Section: golang
Priority: optional
Homepage: https://github.com/Lusitaniae/phpfpm_exporter
Vcs-Browser: https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter
Vcs-Git: https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter.git
Closes bugs: #1077531

Changelog

 prometheus-phpfpm-exporter (0.6.0-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1077531)

QA information

Comments

  1. Nicolas,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Summary...

I believe prometheus-phpfpm-exporter is ready for review/possible sponsorship. Your packages are in great shape and easy to do the basic review upon them.

If you do not have a go team or other regular sponsor, you may wish to change 'Needs a sponsor' to yes and file an RFS bug[6]. A review can be done on the RFS bug and then marked as ready ("confirmed") so that it shows DDs it is ready for final review and possible upload into Debian.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

[6] https://mentors.debian.net/sponsors/rfs-howto/
    Ready Phil Wyett at Oct. 3, 2024, 3:21 p.m. 
  2. Most of the checklist above about Lintian, reproducible builds etc could be automatically validated by Salsa CI. However the current CI in https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter/-/blob/debian/sid/debian/gitlab-ci.yml only runs Golang tests. Would it make sense to expand it to also include the Salsa CI tests?
    Needs work Otto Kekäläinen at Oct. 10, 2024, 3:31 a.m. 
  3. This package depends on https://mentors.debian.net/package/golang-github-tomasen-fcgi-client/, thus I will continue the review of this one once that other has entered Debian first.
    Needs work Otto Kekäläinen at Oct. 23, 2024, 3:43 p.m.

Upload #2

Information

Version: 0.6.0-2
Uploaded: 2024-09-07 18:39
Source package: prometheus-phpfpm-exporter_0.6.0-2.dsc
Distribution: unstable
Section: golang
Priority: optional
Homepage: https://github.com/Lusitaniae/phpfpm_exporter
Vcs-Browser: https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter
Vcs-Git: https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter.git

Changelog

 prometheus-phpfpm-exporter (0.6.0-2) unstable; urgency=medium
 .
   * Update Standards version to 4.7.0, no changes needed
   * Remove trailing whitespaces in debian/rules
   * Add opcache exporter and grafana dashboards to examples
   * Better synopsis and description

QA information

Comments

No comments

Upload #1

Information

Version: 0.6.0-1
Uploaded: 2024-08-02 10:24
Source package: prometheus-phpfpm-exporter_0.6.0-1.dsc
Distribution: unstable
Section: golang
Priority: optional
Homepage: https://github.com/Lusitaniae/phpfpm_exporter
Vcs-Browser: https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter
Vcs-Git: https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter.git
Closes bugs: #1077531

Changelog

 prometheus-phpfpm-exporter (0.6.0-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1077531)

QA information

Comments

  1. Hi,

You have not indicated that you wish a review and sponsorship by toggling "Needs a sponsor" on this page and creating and RFS bug[1].

If you have your own sponsor, you need do nothing. If not please do the above and your package will be looked at in a more timely manner.

[1] https://mentors.debian.net/sponsors/rfs-howto/

Regards

Phil
    Phil Wyett at Aug. 3, 2024, 7:40 a.m.