Ben,
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Error
Running lintian...
N:
E: p2pool-io: custom-library-search-path RUNPATH /usr/lib/x86_64-linux-gnu/android [usr/bin/p2pool]
N:
N: The binary or shared library sets RPATH or RUNPATH. This overrides the
N: normal library search path, possibly interfering with local policy and
N: causing problems for multilib, among other issues.
N:
N: The only time a binary or shared library in a Debian package should set
N: RPATH or RUNPATH is if it is linked to private shared libraries in the
N: same package. In that case, place those private shared libraries in
N: /usr/lib/*package*. Libraries used by binaries in other packages should be
N: placed in /lib or /usr/lib as appropriate, with a proper SONAME, in which
N: case RPATH/RUNPATH is unnecessary.
N:
N: To fix this problem, look for link lines like:
N:
N: gcc test.o -o test -Wl,--rpath,/usr/local/lib
N:
N: or
N:
N: gcc test.o -o test -R/usr/local/lib
N:
N: and remove the -Wl,--rpath or -R argument. You can also use the chrpath
N: utility to remove the RPATH.
N:
N: Please refer to https://wiki.debian.org/RpathIssue for details.
N:
N: Visibility: error
N: Show-Always: no
N: Check: binaries/rpath
N: Renamed from: binary-or-shlib-defines-rpath
N:
N:
I: p2pool-io: extended-description-is-probably-too-short
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is only one or two lines long. The extended
N: description should provide a user with enough information to decide
N: whether they want to install this package, what it contains, and how it
N: compares to similar packages. One or two lines is normally not enough to
N: do this.
N:
N: Please refer to General guidelines for package descriptions (Section
N: 6.2.1) in the Debian Developer's Reference and The long description
N: (Section 6.2.3) in the Debian Developer's Reference for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/description
N:
N:
I: p2pool-io source: quilt-patch-missing-description [debian/patches/system-libraries.patch]
N:
N: quilt patch files should start with a description of patch. All lines
N: before the start of the patch itself are considered part of the
N: description. You can edit the description with quilt header -e when the
N: patch is at the top of the stack.
N:
N: As well as a description of the purpose and function of the patch, the
N: description should ideally contain author information, a URL for the bug
N: report (if any), Debian or upstream bugs fixed by it, upstream status, the
N: Debian version and date the patch was first included, and any other
N: information that would be useful if someone were investigating the patch
N: and underlying problem. Please consider using the DEP 3 format for this
N: information.
N:
N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/quilt
N:
N:
I: p2pool-io: spelling-error-in-binary failt fail [usr/bin/p2pool]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
I: p2pool-io: spelling-error-in-binary heigt height [usr/bin/p2pool]
N:
I: p2pool-io: spelling-error-in-binary nott not [usr/bin/p2pool]
N:
I: p2pool-io: spelling-error-in-binary reponse response [usr/bin/p2pool]
N:
I: p2pool-io: spelling-error-in-binary syste system [usr/bin/p2pool]
N:
P: p2pool-io source: maintainer-manual-page [debian/p2pool.1]
N:
N: The maintainer keeps a manual page in ./debian. Please forward the manual
N: page upstream and ask them to include in their version control system, and
N: in their next release.
N:
N: If the manual page was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/manual-pages
N: Renamed from: maintainer-manpage
N:
E: Lintian run failed (runtime error)
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
Wow... This is a large pull and then exclude.
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Not performed at this time
8. Upgrade [Over previous installs if any]: N/A
Summary...
Issues above need to be resolved.
Please try the below on your packages...
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Needs work
Phil Wyett at Jan. 4, 2025, 5:16 p.m.
