Details about package emacs-window-layout
Package uploads
Upload #1
Information
Changelog
emacs-window-layout (1.4-4) unstable; urgency=medium
.
* Adopted the package as maintainer.
* Updated Standards-Version to 4.7.0.
* Updated debhelper compatibility to 13.
* Added autopkgtest to verify basic functionality.
* debian/watch: added a fake site to explain about
the current status of the original upstream homepage.
Comments
-
Hi,
Bug below needs to be retitled ITA.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053455
The ITA bug then needs to be closed in the 'd/changelog' at the end of the adoption line.
---
Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project.
This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Good
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/emacs-window-layout-1.4$ uscan --force-download
uscan warn: Parameter ../FakeWatchNoUpstreamSiteForThisPackage-0.No-Site.gz does not have a file extension, guessed a tarball compressed with gzip.
Successfully renamed ../FakeWatchNoUpstreamSiteForThisPackage-0.No-Site.gz to ../emacs-window-layout_0.No-Site.orig.tar.gz.
5. Build Twice (build source after successful build [1]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Additional...
A. autopkgtest failure.
Setting up emacs (1:29.4+1-5) ...
Processing triggers for libc-bin (2.40-5) ...
autopkgtest [00:30:44]: test command1: emacs --batch --eval "(progn (require 'window-layout) (window-layout--test-function))"
autopkgtest [00:30:44]: test command1: [-----------------------
Loading /etc/emacs/site-start.d/00debian.el (source)...
Loading /etc/emacs/site-start.d/50emacs-window-layout.el (source)...
Package cl is deprecated
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘destructuring-bind’ is an obsolete alias (as of 27.1); use ‘cl-destructuring-bind’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘destructuring-bind’ is an obsolete alias (as of 27.1); use ‘cl-destructuring-bind’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘return’ is an obsolete alias (as of 27.1); use ‘cl-return’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
Symbol’s function definition is void: window-layout--test-function
Error: void-function (window-layout--test-function)
mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0x6ec34da06517829>))
debug-early-backtrace()
debug-early(error (void-function window-layout--test-function))
(window-layout--test-function)
(progn (require 'window-layout) (window-layout--test-function))
command-line-1(("--eval" "(progn (require 'window-layout) (window-layout--test-function))"))
command-line()
normal-top-level()
autopkgtest [00:30:45]: test command1: -----------------------]
autopkgtest [00:30:45]: test command1: - - - - - - - - - - results - - - - - - - - - -
command1 FAIL non-zero exit status 253
autopkgtest [00:30:45]: test command1: - - - - - - - - - - stderr - - - - - - - - - -
Loading /etc/emacs/site-start.d/00debian.el (source)...
Loading /etc/emacs/site-start.d/50emacs-window-layout.el (source)...
Package cl is deprecated
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘destructuring-bind’ is an obsolete alias (as of 27.1); use ‘cl-destructuring-bind’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘destructuring-bind’ is an obsolete alias (as of 27.1); use ‘cl-destructuring-bind’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘incf’ is an obsolete alias (as of 27.1); use ‘cl-incf’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘return’ is an obsolete alias (as of 27.1); use ‘cl-return’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
../../../../usr/share/emacs/site-lisp/emacs-window-layout/window-layout.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
Symbol’s function definition is void: window-layout--test-function
autopkgtest [00:30:45]: @@@@@@@@@@@@@@@@@@@@ summary
command1 FAIL non-zero exit status 253
E: Autopkgtest run failed.
Summary...
The Orphan/ITA issue needs to be resolved.
autopkgtest issues.
'd/watch' file issues.
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'.
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Regards
Phil
Needs work
Phil Wyett at Jan. 17, 2025, 12:35 a.m.