Sign me up Login

Details about package audacious

Name: audacious (PTS)
Uploader: Mateusz Łukasik <mati75@linuxmint.pl> (Debian QA page)
Description: audacious - small and fast audio player which supports lots of formats
audacious-dev - audacious development files
libaudcore5t64 - audacious core engine library
libaudgui6 - audacious media player (libaudgui shared library)
libaudtag3t64 - audacious media player (libaudtag shared library)
libaudqt3 - audacious media player (libaudqt shared library)

Package uploads

Upload #3

Information

Version: 4.4.2-1
Uploaded: 2025-01-09 20:41
Source package: audacious_4.4.2-1.dsc
Distribution: unstable
Section: sound
Priority: optional
Homepage: https://www.audacious-media-player.org/
Vcs-Browser: https://salsa.debian.org/multimedia-team/audacious
Vcs-Git: https://salsa.debian.org/multimedia-team/audacious.git

Changelog

 audacious (4.4.2-1) unstable; urgency=medium
 .
   * New upstream release.
   * Revert Remove COPYING file from install. Add override for
     extra-license-file.
   * Welcome 2025 in d/copyright.
   * Add override for appstream-metadata-validation-failed.

QA information

Comments

  1. Mateusz,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice (build source after successful build [1]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Sumamry...

Nicely done, looks good to me. If you do not have a regular sponsor, you can use the Request For Sponsorship (RFS) process below.

https://mentors.debian.net/sponsors/rfs-howto/

Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
  
Regards

Phil
    Ready Phil Wyett at Jan. 10, 2025, 7:13 p.m.

Upload #2

Information

Version: 4.4.2-1
Uploaded: 2025-01-03 19:56
Source package: audacious_4.4.2-1.dsc
Distribution: unstable
Section: sound
Priority: optional
Homepage: https://www.audacious-media-player.org/
Vcs-Browser: https://salsa.debian.org/multimedia-team/audacious
Vcs-Git: https://salsa.debian.org/multimedia-team/audacious.git

Changelog

 audacious (4.4.2-1) unstable; urgency=medium
 .
   * New upstream release.
   * Revert Remove COPYING file from install.

QA information

Comments

  1. Mateusz,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue

I: audacious: extra-license-file [usr/share/audacious/COPYING]
N: 
N:   All license information should be collected in the debian/copyright file.
N:   This usually makes it unnecessary for the package to install this
N:   information in other places as well.
N: 
N:   Please refer to Copyright information (Section 12.5) in the Debian Policy
N:   Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: files/licenses

I: libaudcore5t64: unused-override package-name-doesnt-match-sonames libaudcore5 [usr/share/lintian/overrides/libaudcore5t64:1]
N: 
N:   Your package specifies the named override but there were no tags that
N:   could have been silenced by it.
N:   
N:   Maybe you fixed an underlying condition but forgot to remove the override.
N:   It is also possible that the Lintian maintainers fixed a false positive.
N:   
N:   If the override is now unused, please remove it.
N:   
N:   This tag is similar to mismatched-override except there a tag could have
N:   been silenced if the context had matched.
N:   
N:   Sometimes, overrides end up not being used because a tag appears only on
N:   some architectures. In that case, overrides can be equipped with an
N:   architecture qualifier.
N: 
N:   Please refer to Architecture specific overrides (Section 2.4.3) in the
N:   Lintian User's Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: yes
N:   Check: lintian

I: libaudtag3t64: unused-override package-name-doesnt-match-sonames libaudtag3 [usr/share/lintian/overrides/libaudtag3t64:1]
N:
P: audacious source: trailing-whitespace [debian/changelog:25]
N: 
N:   This file contains lines with trailing whitespace characters.
N:   
N:   Whilst often harmless and unsightly, such extra whitespaces can also cause
N:   tools to interpret the whitespace characters literally. The tool diff(1)
N:   does not like them, either. They are best avoided.
N:   
N:   Some of these problems can be hard to track down.
N:   
N:   Whitespace at the end of lines may be removed with the following:
N:   
N:    $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:   
N:   If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:   
N:   However, if you wish to only remove trailing spaces and leave trailing
N:   tabs (eg. for Makefiles), you can use the following code snippet:
N:   
N:    $ sed -i -e 's@[ ]*$@@g' debian/rules
N:   
N:   To remove empty lines from the end of a file, you can use:
N:   
N:    $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/trailing-whitespace
N:   Renamed from: file-contains-trailing-whitespace

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

Just a few lintian things to look at.

Please try the below on your packages...

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
  
Regards

Phil
    Needs work Phil Wyett at Jan. 4, 2025, 1:44 p.m.

Upload #1

Information

Version: 4.4.1-1
Uploaded: 2024-10-27 15:26
Source package: audacious_4.4.1-1.dsc
Distribution: unstable
Section: sound
Priority: optional
Homepage: https://www.audacious-media-player.org/
Vcs-Browser: https://salsa.debian.org/multimedia-team/audacious
Vcs-Git: https://salsa.debian.org/multimedia-team/audacious.git

Changelog

 audacious (4.4.1-1) unstable; urgency=medium
 .
   * New upstream release.

QA information

Comments

  1. Mateusz,

Preamble...

Thank you for taking the time to prepare this package and your contribution to the Debian project.

The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Information, none blocking

I: libaudcore5t64: unused-override package-name-doesnt-match-sonames libaudcore5 [usr/share/lintian/overrides/libaudcore5t64:1]
N: 
N:   Your package specifies the named override but there were no tags that
N:   could have been silenced by it.
N:   
N:   Maybe you fixed an underlying condition but forgot to remove the override.
N:   It is also possible that the Lintian maintainers fixed a false positive.
N:   
N:   If the override is now unused, please remove it.
N:   
N:   This tag is similar to mismatched-override except there a tag could have
N:   been silenced if the context had matched.
N:   
N:   Sometimes, overrides end up not being used because a tag appears only on
N:   some architectures. In that case, overrides can be equipped with an
N:   architecture qualifier.
N: 
N:   Please refer to Architecture specific overrides (Section 2.4.3) in the
N:   Lintian User's Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: yes
N:   Check: lintian

I: libaudtag3t64: unused-override package-name-doesnt-match-sonames libaudtag3 [usr/share/lintian/overrides/libaudtag3t64:1]
N:
P: audacious source: trailing-whitespace [debian/changelog:24]
N: 
N:   This file contains lines with trailing whitespace characters.
N:   
N:   Whilst often harmless and unsightly, such extra whitespaces can also cause
N:   tools to interpret the whitespace characters literally. The tool diff(1)
N:   does not like them, either. They are best avoided.
N:   
N:   Some of these problems can be hard to track down.
N:   
N:   Whitespace at the end of lines may be removed with the following:
N:   
N:    $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:   
N:   If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:   
N:   However, if you wish to only remove trailing spaces and leave trailing
N:   tabs (eg. for Makefiles), you can use the following code snippet:
N:   
N:    $ sed -i -e 's@[ ]*$@@g' debian/rules
N:   
N:   To remove empty lines from the end of a file, you can use:
N:   
N:    $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/trailing-whitespace
N:   Renamed from: file-contains-trailing-whitespace

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

I believe audacious is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
    Ready Phil Wyett at Nov. 1, 2024, 10:05 a.m. 
  2. I will take a look at sponsoring this.
    Soren Stoutner at Dec. 30, 2024, 10:04 p.m.